Skip to content

GPU Clusterizer: synchronize the cluster transfer to the host before sorting the clusters - #16168

Merged
davidrohr merged 1 commit into
AliceO2Group:devfrom
ktf:pr16168
Nov 21, 2026
Merged

davidrohr merged 1 commit into
AliceO2Group:devfrom
ktf:pr16168

Conversation

@ktf

@ktf ktf commented Nov 21, 2026

Copy link
Copy Markdown
Member

In deterministic mode (or with debugLevel >= 4), the clusters are copied
from the GPU to the host on the last stream, sorted on the host, and
copied back to the GPU. The copy to the host was only waited for with
synchronizeOutput, which RunTPCClusterizer gets as false, so the host
sorted a partially transferred buffer, still holding the previous time
frame's clusters, and uploaded the result: the clusters seen by the
tracking, and the track counts, changed from run to run.

…sorting the clusters

In deterministic mode (or with debugLevel >= 4), the clusters are copied
from the GPU to the host on the last stream, sorted on the host, and
copied back to the GPU. The copy to the host was only waited for with
synchronizeOutput, which RunTPCClusterizer gets as false, so the host
sorted a partially transferred buffer, still holding the previous time
frame's clusters, and uploaded the result: the clusters seen by the
tracking, and the track counts, changed from run to run.
@ktf
ktf requested a review from davidrohr as a code owner November 21, 2026 12:45
@ktf

ktf commented Nov 21, 2026

Copy link
Copy Markdown
Member Author

This is part of the reproducibility issue on macOS with the Phase 2 development PR. The issue itself predates the development, though, so I guess we can merge it as a separate PR.

I will open another PR with the two other related fixes for reproducibility.

@davidrohr
davidrohr merged commit 03da3ee into AliceO2Group:dev Nov 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants