Skip to content

Keep the workflow printout in run-workflow-on-inputlist.sh - #16169

Merged
sawenzel merged 1 commit into
AliceO2Group:devfrom
sawenzel:fix-inputlist-log-race
Nov 21, 2026
Merged

sawenzel merged 1 commit into
AliceO2Group:devfrom
sawenzel:fix-inputlist-log-race

Conversation

@sawenzel

@sawenzel sawenzel commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

This is fixing a bug where the printed workflow could be missing from the stdout of run-workflow-on-inputlist.sh.

  • The output was copied to stdout by a tail started after one second and killed when the workflow ended.
  • When the workflow had already ended, tail could be killed before printing anything.
  • tail now follows a sentinel process with --pid, which is stopped only after all processes are done, so tail exits by itself after printing everything.
  • The final wait for tail is limited to 10 s, with a warning if it has to be stopped.

This affected the extraction of the reco configuration in anchored MC (anchorMC.sh).

Note that the logging now relies on GNU tail (--pid), like the rest of the script relies on Linux.

https://its.cern.ch/jira/browse/O2-7359

This is fixing a bug where the printed workflow could be missing from the stdout of run-workflow-on-inputlist.sh.

- The output was copied to stdout by a tail started after one second and killed when the workflow ended.
- When the workflow had already ended, tail could be killed before printing anything.
- tail now follows a sentinel process with --pid, which is stopped only after all processes are done.
- The final wait for tail is limited to 10 s, with a warning if it has to be stopped.

https://its.cern.ch/jira/browse/O2-7359

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sawenzel
sawenzel force-pushed the fix-inputlist-log-race branch from 41867e2 to 62e46cd Compare November 21, 2026 17:30
@sawenzel
sawenzel merged commit e57ba61 into AliceO2Group:dev Nov 21, 2026
12 checks passed
@sawenzel
sawenzel deleted the fix-inputlist-log-race branch November 21, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant