Repository navigation
Add least-connections load balancing across resolved addresses - #2400
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
A host that resolves to several IPs gets its connections on the first address in
DEFAULTmode, andROUND_ROBINrotates per request without regard to how many connections each address already holds.Modification:
Add
LoadBalance.LEAST_CONNECTIONS. When a new direct connection is opened to a multi-address host,LeastConnectionsAddressSelectorpicks the address with the fewest connections open or opening from this client. The failed-IP cooldown outranks the count, and ties keep resolver order. Failover picks the same way among the addresses not tried yet, preferring the address family with fewer failed attempts.NettyChannelConnectorcounts each attempt and releases it once, on connect failure or channel close. Pooling and the HTTP/2 registry stay per host.Result:
Concurrent HTTP/1.1 requests spread their connections evenly across a host's addresses. HTTP/2 keeps one connection per host, so the mode only chooses where a replacement or racing connection goes.
DEFAULTandROUND_ROBINare unchanged.Fixes #2397