Repository navigation
Conversation
Allow a terminal /** in path_template so one path-placed credential serves multiple API methods while preserving exact templates and endpoint authorization. Keep the credential slot anchored and reject duplicate, misplaced, and traversal-bearing references. Cover long-polling getUpdates alongside sendMessage using one HTTP client and one credential through the production REST relay. Update provider documentation and CLI guidance. Closes NVIDIA#5544 Signed-off-by: Luomu <enrondg@gmail.com>
|
All contributors have signed the DCO ✍️ ✅ |
|
I have read the DCO document and I hereby sign the DCO. |
|
/ok to test c89a978 |
|
Label |
PR Review StatusThe initial code review found no blocking findings. The subtree matching keeps the credential in its declared slot, preserves separate endpoint authorization, and includes regression coverage plus provider documentation updates. I applied Blocking findings:
Carried findings:
Non-blocking suggestions:
Gator metadata
|
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. configuration — No explicit risk acceptance found
Review details
Advisory review; publication gates are unchanged. |
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
|
/ok to test 0e4eb42 |
PR Review StatusThe follow-up code review found no blocking findings. The new I refreshed the test mirror for this head and approved the required Trivy workflow. Helm Lint passed; Branch Checks, E2E, and Trivy are queued or running. Gator will inspect their results next cycle. Blocking findings:
Carried findings:
Gator metadata
|
Signed-off-by: Luomu <enrondg@gmail.com>
|
/ok to test c3ea334 |
PR Review StatusThe follow-up review found no blocking findings. Both previously reviewed author commits are unchanged; the merge resolution adopts the upstream provider overview, and the profile documentation retains the explicit I refreshed the test mirror for this head and authorized the required Trivy workflow. Helm Lint passed; Branch Checks and E2E are running, and Trivy is queued. Gator will inspect the results next cycle. Blocking findings:
Carried findings:
Gator metadata
|
Summary
Allow a terminal
/**in a credential'spath_templateso a bot can use one token forgetUpdates,sendMessage, and other API methods. Templates without that suffix retain exact matching, and the credential must remain in its declared path slot.Related Issue
Closes #5544
Changes
/**suffix.getUpdatespending, completesendMessagewith the same credential, and only then release the polling response./bot{credential}/**example.Release Notes
Testing
Validation:
Rust checks use the repository-pinned Rust 1.95.0 toolchain with default features:
cargo fmt -p openshell-core -p openshell-supervisor-network -- --check— passed.cargo clippy --locked -p openshell-core -p openshell-supervisor-network --all-targets -- -D warnings— passed.cargo test --locked -p openshell-core -p openshell-supervisor-network --lib— 2,378 passed, 2 ignored (655 core tests and 1,723 network tests).npx --yes markdownlint-cli2@0.22.0 docs/how-it-works/providers/overview.mdx docs/how-it-works/providers/profiles.mdx skills/openshell-cli/SKILL.md— passed before rebasing, 0 errors. The documentation edits were unchanged by the rebase; a rerun was unavailable in this environment.uv run tasks/scripts/check_docs_nav.py— passed.The concurrent test uses a shared HTTP client and production request parsing, credential resolution, body forwarding, and response relay against a loopback Bot API fixture. Live Telegram SDK/API and sandbox E2E tests were not run. Fern strict validation was not run in this environment.
Checklist