Repository navigation
build: pin V8 v8-14.9.207.39-12 - #596
Draft
edusperoni wants to merge 1 commit into
Draft
edusperoni wants to merge 1 commit into
edusperoni wants to merge 1 commit into
Conversation
Adds the declined masking-interceptor store fast path (NativeScript/v8-buildscripts#15): when a masking named interceptor declines a store to a name the receiver already has as an own fast data field, the store IC overwrites the field instead of calling Runtime_StorePropertyPastInterceptor. --store-ic-declined-interceptor-fast-path, on by default. Public headers are unchanged from -11.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins V8
v8-14.9.207.39-12. The only change from -11 is NativeScript/v8-buildscripts#15. Public headers are unchanged.What the patch does
When a masking named interceptor declines a store (
Intercepted::kNo) and the receiver already has that name as an own, writable, fast-mode data field, the store IC overwrites the field directly. Before, it always finished the store inRuntime_StorePropertyPastInterceptor, which redoes the lookup and runs a genericSetProperty. The flag--store-ic-declined-interceptor-fast-pathis on by default. Global, define-own and dictionary-mode stores never take the fast path.In this runtime, that is every rewrite of a JS property on a masking (mirroring) canary: the setter mirrors the write into the state, then declines.
Measured
iPhone 11 Pro, jitless, Release, canary/all. Fast path on vs off in one binary (the PR's device libs):
On Mac Catalyst (JIT) the same write is about 1.4× faster. Unchanged: native calls, new-name writes, native property writes (they end at a prototype accessor, not an own field), reads.
Testing
Suite on this branch with the released libs, 2169 specs, 0 failures in
resurrecting/extended,canary/all,rooted/allandcanary/allunder ASan.