Skip to content

build: pin V8 v8-14.9.207.39-12 - #596

Draft
edusperoni wants to merge 1 commit into
mainfrom
build/v8-14.9.207.39-12
Draft

edusperoni wants to merge 1 commit into
mainfrom
build/v8-14.9.207.39-12

Conversation

@edusperoni

Copy link
Copy Markdown
Collaborator

Pins V8 v8-14.9.207.39-12. The only change from -11 is NativeScript/v8-buildscripts#15. Public headers are unchanged.

What the patch does

When a masking named interceptor declines a store (Intercepted::kNo) and the receiver already has that name as an own, writable, fast-mode data field, the store IC overwrites the field directly. Before, it always finished the store in Runtime_StorePropertyPastInterceptor, which redoes the lookup and runs a generic SetProperty. The flag --store-ic-declined-interceptor-fast-path is on by default. Global, define-own and dictionary-mode stores never take the fast path.

In this runtime, that is every rewrite of a JS property on a masking (mirroring) canary: the setter mirrors the write into the state, then declines.

Measured

iPhone 11 Pro, jitless, Release, canary/all. Fast path on vs off in one binary (the PR's device libs):

Write Off On
Expando rewrite 172 ns 129 ns (−43)
Expando rewrite next to a native call ~196 ns ~143 ns (−52)

On Mac Catalyst (JIT) the same write is about 1.4× faster. Unchanged: native calls, new-name writes, native property writes (they end at a prototype accessor, not an own field), reads.

Testing

Suite on this branch with the released libs, 2169 specs, 0 failures in resurrecting/extended, canary/all, rooted/all and canary/all under ASan.

Adds the declined masking-interceptor store fast path (NativeScript/v8-buildscripts#15): when a masking named interceptor declines a store to a name the receiver already has as an own fast data field, the store IC overwrites the field instead of calling Runtime_StorePropertyPastInterceptor. --store-ic-declined-interceptor-fast-path, on by default. Public headers are unchanged from -11.
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant