Skip to content

Add opt-in arm64 Android V8 builds with Intl, WebAssembly and JIT - #16

Open
matthargett wants to merge 3 commits into
NativeScript:mainfrom
rebeckerspecialties:android-intl-wasm-jit
Open

matthargett wants to merge 3 commits into
NativeScript:mainfrom
rebeckerspecialties:android-intl-wasm-jit

Conversation

@matthargett

@matthargett matthargett commented Nov 22, 2026 •

Copy link
Copy Markdown

Why

Android embedders that use browser application bundles (BabylonJS webXR app in BabylonNative on Oculus Quest 1, in my case) need locale-sensitive dates and numbers as well as WebAssembly. The existing Android artifacts and their CPU baseline remain unchanged. Following the variant approach in #9 and the Android consumer use case in NativeScript/NativeScript#11563, this adds an opt-in android-intl matrix for Android 10+ arm64.

What changes

  • Build a portable arm64 artifact and a separately named CRC/crypto artifact tuned for Cortex-A73 (-march=armv8-a+crc+crypto -mtune=cortex-a73). Only opt into the latter on compatible hardware.
  • Enable Intl, WebAssembly and JIT with size optimization and ThinLTO; keep PGO disabled. Package the snapshot and ICU with the monolith so callers do not have to locate additional data files at startup.
  • Ship the generated public v8-gn.h. Embedders compile their translation units with -DV8_GN_HEADER so isolate and handle layouts match the archive. Link an executable and a shared embedder with NDK r29, including a no-undefined link and an Android 10 ELF TLS alignment check.

Validation

Both fork CI builds passed at 7d810e817b4cce7f254237d624f50865ed64a373, V8 14.9.207.39. Both packaged intl-smoke executables ran unchanged on a physical Oculus Quest 1 (Android API 29). Each formatted 1234.5 as 1.234,5 in de-DE, obtained 1970 for the UTC epoch year, and compiled, instantiated and called a Wasm export that returned 42. SHA-256 of each installed executable matched the downloaded CI artifact.

@coderabbitai

coderabbitai Bot commented Nov 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5e00f2f0-cae5-4159-b6d4-9778fff7e8b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant