Repository navigation
Add opt-in arm64 Android V8 builds with Intl, WebAssembly and JIT - #16
Open
matthargett wants to merge 3 commits into
Open
matthargett wants to merge 3 commits into
matthargett wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Android embedders that use browser application bundles (BabylonJS webXR app in BabylonNative on Oculus Quest 1, in my case) need locale-sensitive dates and numbers as well as WebAssembly. The existing Android artifacts and their CPU baseline remain unchanged. Following the variant approach in #9 and the Android consumer use case in NativeScript/NativeScript#11563, this adds an opt-in
android-intlmatrix for Android 10+ arm64.What changes
-march=armv8-a+crc+crypto -mtune=cortex-a73). Only opt into the latter on compatible hardware.v8-gn.h. Embedders compile their translation units with-DV8_GN_HEADERso isolate and handle layouts match the archive. Link an executable and a shared embedder with NDK r29, including a no-undefined link and an Android 10 ELF TLS alignment check.Validation
Both fork CI builds passed at
7d810e817b4cce7f254237d624f50865ed64a373, V8 14.9.207.39. Both packagedintl-smokeexecutables ran unchanged on a physical Oculus Quest 1 (Android API 29). Each formatted1234.5as1.234,5inde-DE, obtained1970for the UTC epoch year, and compiled, instantiated and called a Wasm export that returned42. SHA-256 of each installed executable matched the downloaded CI artifact.