Repository navigation
Conversation
nazar-pc
requested review from
Firestar99,
LegNeato and
eddyb
as code owners
November 18, 2026 17:14
The `core` implementation of these methods branches on whether the shift amount is less than the bit width, which turns into structured control flow with an `OpPhi`. It also goes through `unchecked_shl`/`unchecked_shr`, whose precondition check forces callers to be inlined because of the panic path. Intercept calls to the integer `unbounded_shl`/`unbounded_shr` methods from `core` and emit the shift followed by an `OpSelect` on whether the shift amount is in range, since SPIR-V leaves shifts by the bit width or more undefined. Signed `unbounded_shr` clamps the shift amount to `BITS - 1` instead, which fills the result with the sign bit.
nazar-pc
force-pushed
the
unbounded-shifts
branch
from
November 18, 2026 17:24
ced94f3 to
5c571db
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #403.
Essentially reduces this:
Into this:
And hopefully optimizes better in a driver (though I have not benchmarked it).
Implemented by a clanker, but looks reasonable to me.