Skip to content

Ghi14680 state condition - #14739

Open
DaanHoogland wants to merge 2 commits into
mainfrom
ghi14680-stateCondition
Open

DaanHoogland wants to merge 2 commits into
mainfrom
ghi14680-stateCondition

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR fixes a condition that leads to detaching of destoyed volumes not being possible.

Relates to #14680 but would probably not solve OP's problem

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland added this to the 24.0 milestone Nov 20, 2026
@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.81%. Comparing base (2f34b0c) to head (33526a6).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14739      +/-   ##
============================================
+ Coverage     20.77%   20.81%   +0.03%     
- Complexity    20847    20925      +78     
============================================
  Files          6053     6053              
  Lines        548222   548451     +229     
  Branches      73236    73279      +43     
============================================
+ Hits         113896   114137     +241     
+ Misses       420984   420949      -35     
- Partials      13342    13365      +23     
Flag Coverage Δ
uitests 3.86% <ø> (-0.01%) ⬇️
unittests 22.24% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 25.74%
Branch coverage 20.93%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant