Repository navigation
Conversation
AccountDetailsDao.persist() removes every detail of the account before it writes the given ones, so the first bucket of an account removed its account-scoped settings.
… store The keys were stored in plain text under one name per account, so a second Ceph object store replaced the keys of the first one. They are now stored encrypted with the ID of the store in their name; keys stored before are still read. Secret keys in the account details are no longer returned by listAccounts.
Both were accepted and recorded on the bucket, but never set in RGW.
The admin API removed the bucket with all its objects. The S3 API fails with BucketNotEmpty instead.
- a failed lookup of the RGW user was taken for a missing user - an existing RGW user without stored keys made the bucket creation fail with a NullPointerException, its keys are stored now - the error of an existing bucket was wrapped twice - adding an object store without credentials failed without the cause
A new client, with its own connection pool, was built for every call and never closed.
…lash The admin access key and the names of all buckets are no longer logged when the object store is added.
The public policy allowed everyone to list the objects of the bucket, it now only allows reading them. A policy other than public or private was applied as private and is refused now.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14740 +/- ##
============================================
+ Coverage 20.78% 20.81% +0.03%
- Complexity 20858 20927 +69
============================================
Files 6053 6053
Lines 548237 548440 +203
Branches 78619 73281 -5338
============================================
+ Hits 113935 114175 +240
+ Misses 420953 420900 -53
- Partials 13349 13365 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes for the Ceph RGW object store driver, one per commit:
listAccountsTypes of changes
How Has This Been Tested?
Unit tests only, not yet tested against a live RGW.