Skip to content

Use uppercase TCP in the Helm extraPorts example - #8146

Open
NotAFlightRisk wants to merge 1 commit into
coder:mainfrom
NotAFlightRisk:helm-extra-ports-protocol
Open

NotAFlightRisk wants to merge 1 commit into
coder:mainfrom
NotAFlightRisk:helm-extra-ports-protocol

Conversation

@NotAFlightRisk

Copy link
Copy Markdown

Uncommenting the extraPorts example in the chart's values.yaml and installing gets you this:

$ helm template code-server ci/helm-chart -f extra-ports.yaml | kubectl apply --dry-run=server -f -
Error from server (Invalid): error when creating "STDIN": Service "code-server" is invalid: spec.ports[1].protocol: Unsupported value: "tcp": supported values: "SCTP", "TCP", "UDP"
Error from server (Invalid): error when creating "STDIN": Deployment.apps "code-server" is invalid: spec.template.spec.containers[0].ports[1].protocol: Unsupported value: "tcp": supported values: "SCTP", "TCP", "UDP"

extra-ports.yaml there is just the example with the #s taken off. Kubernetes only takes the protocol in capitals and the templates pass it through as written, so it needs to say TCP. With that the same dry run goes through fine (tried against a k3s 1.31 server).

There's no issue for this one - it's one word in a comment, which I figured counts as minor.

AI helped with this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant