Repository navigation
test: update api snapshots for DevframeDiagnostics type output - #500
Merged
Merged
Conversation
After the deps update, the built .d.ts files reference DevframeDiagnostics from devframe/utils/nostics instead of inlining nostics types. tsnapi flags this as narrowed, but callers see the same API.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
👁️🗨️ Review this pull request with grouped, summarized diffs at: raw result💭 analyzed by {
"headSha": "158cb1ee1c2f7de355a96f84a6fe1ad4fa228fec",
"result": {
"overallSummary": "CI on `main` fails on 3 tsnapi API snapshots because recent dependency updates changed how the built `.d.ts` output expresses the `diagnostics` export's type (now via `DevframeDiagnostics` instead of inlined `nostics` types), not because the source API changed. This PR simply regenerates those snapshots with `TSNAPI_ALLOW_BREAKING=1` to unblock CI for this and other open PRs.",
"groups": [
{
"key": "snapshot-updates",
"label": "Update tsnapi snapshots",
"summary": "Regenerates stale tsnapi API snapshots to match the updated built `.d.ts` output, where `diagnostics` now resolves through `DevframeDiagnostics` (imported from `devframe/utils/nostics`) instead of inlining `nostics`'s `Diagnostic`/`Diagnostics` types. No source API changed; this only unblocks CI, which fails the same way on `main`.",
"category": "tests",
"filePaths": [
"tests/__snapshots__/tsnapi/@devframes/plugin-code-server/node.snapshot.d.ts",
"tests/__snapshots__/tsnapi/@devframes/plugin-terminals/node.snapshot.d.ts",
"tests/__snapshots__/tsnapi/devframe/internal.snapshot.d.ts"
],
"fileNotes": [
{
"path": "tests/__snapshots__/tsnapi/devframe/internal.snapshot.d.ts",
"text": "The reporters type argument now prints as `[]` instead of the inline reporter tuple; this is expected since `DevframeDiagnostics` prepends devframe's reporter implicitly rather than listing it in the type. Not formally proven equivalent to the old type (see PR description), only verified by caller-facing type-check against the built output."
}
]
}
],
"schemaVersion": 1,
"source": "llm",
"generatedAt": "2026-11-19T01:28:40.704Z",
"model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
"locale": "en"
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainfails on 3 tsnapi API snapshots since the deps update in 72a4814 / 13b26a3. The last 3mainCI runs fail the same way, and every open PR inherits it (for example #498).The built
.d.tsoutput changed, not the source API:devframe/internal:diagnosticsis now typedDevframeDiagnostics<{...}, []>(imported from../utils/nostics.mjs) instead ofimport("nostics").Diagnostics<{...}, readonly [reporter], never>.@devframes/plugin-terminalsand@devframes/plugin-code-server(./node): the same, and they no longer inline copies ofnostics'sDiagnosticclass andDiagnosticstype.This is the output the
DevframeDiagnosticsdoc comment inpackages/devframe/src/utils/nostics.tsasks for: references resolve throughdevframe/utils/nosticsand do not inlinenosticstypes.tsnapi reports
~ narrowed diagnosticsand refuses a plain-u, because the second type argument now prints as[]. That[]is the extra-reporters argument ofDevframeDiagnostics, which still prepends devframe's reporter. So I updated withTSNAPI_ALLOW_BREAKING=1.User prompts
Model: Claude Opus 5.5 in Claude Code (via Paseo).
main. The user chose to fix them in a separate PR.Verification
pnpm build, thenTSNAPI_ALLOW_BREAKING=1 pnpm exec vitest run --project tests tests/exports.test.ts -u: 3 snapshots updated.pnpm exec vitest run --project tests tests/exports.test.ts: 246 passed, 9 skipped.packages/devframe/dist/internal/index.d.mts(throwaway file,tsc --strict, exit 0):diagnostics.DF0006({ name: 'x' }, { method: 'warn' })type-checks, so the reporter option is still typed.{ method: 'bogus' }and a missingnameboth fail, checked with@ts-expect-error.diagnosticstypes. Myinfer-based attempt could not pull the type parameters out, so it proved nothing either way.This PR was written by an agent. The human chose to fix this separately; they have not reviewed the diff yet.