Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #691.
Add
Legend.BackgroundColorto fill behind legend entries before drawing their thumbnails and labels. The default nil color keeps the background transparent; empty legends do not paint a background.Calculate the legend rectangle from the same entry positions used by drawing, including offsets. This also corrects the previous horizontal anchoring and vertical extents. Plain-text glyph bounds account for descenders, italic overhangs, multiline labels and rotation. Entry drawing positions are preserved. Other text handlers retain their existing layout-bounds contract.
Add a public background example, image comparisons and geometry regressions covering all four corners, vertical positions/alignment, offsets, italic multiline text, rotation, empty legends and zero-size fonts. Regenerate only the standalone-legend golden (corrected outlines) and the new background golden.
Validation on Go 1.26.6 / Linux:
go test -trimpath -p 1 ./...: all packages pass.-trimpathnormalizes source paths for the existing recorder test. Without it, that unchanged package expects an import-relative path but receives this checkout's absolute path; its targeted test passes with the flag.