Repository navigation
X: McXtrace: Mirror_curved - follow-up after #3137 - #3151
Merged
Merged
Conversation
5 of 32 tasks
Contributor
Author
|
debian/arm64 test |
Contributor
Author
|
All is fine to me... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X: McXtrace: Mirror_curved - follow-up after #3137
This is a follow-up after #3137.
Fixes:
MAXII_811exits when run with defaults: FixedTest_KB,MAXII_811andJJ_SAXS. FixedTest_KBline. FixedSuggestion: one quadric instead of four branches Not done, as this would again change things. Perhaps in a future PR 😄
On the PR size
The change of the
Mirror_curveddid trigger other updates, which were unavoidable - and thus attached to #3137:MAXII_811DCM was non-functional, and let the beam pass through, just as the curved mirrors in the KB. The alignment of the beam had to be fixed. In the past model, the non reflected beam would go through (after DCM and mirrors), causing a much higher flux indeed (white - direct). This was clearly an error.JJ_SAXSwas completely broken and unusable. This model with the curved mirror could not be used for testing. It had to be fixed, or removed. It was written in the header to be a "sketchy" model, indeed, but not a SAXS for sure.Test_KBrequired to demonstrate the focusing, for a thorough validation.SOLEIL_PUMAhad a broken KB arrangement, that appeared after mirror upgrade.I have run the mctest, and all is fine. The mcdoc for component reports OK.
Declaration of use of AI-tools
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution includes patches to an existing component file
mcdocutility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)mctestutility to test one or more instruments making use of the component (please attachmcviewtestreport as screenshot in comments)mccode-clangformattool to apply the standard McCode component indentation schememcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedMy contribution includes patches to an existing instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)mctestutility to test the instrument (please attachmcviewtestreport as screenshot in comments)mcrun --c-lint"linter" and followed advice to remove most / all warnings that are raised