Repository navigation
fix(sensevoice): keep event dedupe state across text segments - #3931
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3930
When the same event starts three language segments in a row and the middle one has text,
rich_transcription_postprocessshowed the emoji again on the third one:👏hello world👏againinstead of👏hello world again. After removing the repeated emoji, the loop read the event again from the stripped text, so it becameNone. Now the segment's event is read once before stripping and kept as the current event. Same change in the core, onnx and libtorch copies.Type of change
Validation
python -m pytest tests/test_rich_transcription_event_segments.py tests/test_rich_transcription_postprocess.py -q: 63 passed.test_repeated_event_with_text_across_three_segments(Cough/Sneeze/Applause × 3 modules) fails on main with 9 failures and passes with the fix.test_different_event_between_same_events_keeps_all_emojischecks that Applause, Laughter, Applause still keeps all three emojis.python -m compileallon the changed filesUser impact
People using SenseVoice with rich transcription get a cleaner transcript when an event like applause or coughing goes on over several segments. Before, the emoji kept popping back every other segment.
Notes for reviewers
Only the event state changes. Event-only segments, emotion handling and spacing work the same as before.
🤖 Generated with Claude Code