Repository navigation
Sync the qasm3 grammar copy with OpenQASM AST 1.0.2 - #44
Open
HVSharma12 wants to merge 1 commit into
Open
HVSharma12 wants to merge 1 commit into
HVSharma12 wants to merge 1 commit into
Conversation
openqasm3 1.0.2's visitor calls quantumCallExpression(), which the old copy lacks, so every assignment in a cal block raises AttributeError. Copied from openqasm/openqasm at ast-py/v1.0.2. Signed-off-by: HVSharma12 <harshvardhan.sharma@suse.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43.
This copies
qasm3Lexer.g4andqasm3Parser.g4from openqasm/openqasm atast-py/v1.0.2, which match its current main. With it, assignments incalblocks parse again with openqasm3 1.0.2, and the full test suite passes with both 1.0.2 and 1.0.1. Before,test_annotation_in_cal_blockfailed with 1.0.2.The copy also brings in the other differences listed in #42, which are
nop, quantum call expressions, empty array literals, dotted annotation keywords, the removed~=operator and comments on the hidden channel.