Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Replace the deprecated
@pytest.mark.tryfirstmarker onpytest_addhooksindash/testing/plugin.pywith@pytest.hookimpl(tryfirst=True).Problem and behavior
Pytest deprecated configuring hook implementations via
@pytest.mark.*in pytest 7.2 (PytestRemovedIn10Warning: The hookimpl pytest_addhooks uses old-style configuration options (marks or attributes)) and removes support in pytest 10. Becausedash.testing.pluginis registered via thepytest11entry point, any test suite running in an environment withdashinstalled receives this warning on startup and fails under-W erroror pytest 10.Fixes #2420
Validation
dash.testing.pluginonpytest.PytestPluginManager()emittedPytestRemovedIn10Warning.pytest -p no:dash -p dash.testing.plugin -W error::pytest.PytestRemovedIn10Warning tests/unit/test_testing.py -v(2 passed).black --checkandflake8 --config .flake8ondash/testing/plugin.pyandtests/unit/test_testing.py.Contributor Checklist
dev(fix or chore) ornext(feature, new API, breaking change), see Which branch to target@pytest.mark.tryfirstwith@pytest.hookimpl(tryfirst=True)onpytest_addhookstest_tst002_pytest_addhooks_uses_hookimplandCHANGELOG.mdentryoptionals
CHANGELOG.md