Repository navigation
Conversation
dagre 0.8.5 throws "Cannot set properties of undefined (setting 'order')" on some graph shapes (seen on the Dash docs app, 598 callbacks), which replaced the whole callback graph with an error. Run the layout ourselves instead of through CytoscapeComponent's layout prop, catch the failure, lay out with fcose and show a short note.
Contributor
Dash performance benchmarks
growth = late-third / early-third per-op time; ~1 is flat, a large value means the per-op cost scales with accumulated state. machine scale vs baseline: 1.11x - divided out of the baseline ratios so they compare like for like (the absolute warn/fail ceilings are left un-scaled); calibrated on |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Opening the callback graph in dev tools crashes on some apps with
Cannot set properties of undefined (setting 'order')(Firefox:can't access property "order", g.node(...) is undefined), and the panel shows "Oops! The callback graph threw an error." Found on the Dash docs app (598 callbacks).The error comes from dagre 0.8.5 itself, on some graph shapes. It isn't new in 4.5: dagre and the
tight-treeranker haven't changed since 2020. Switching rankers doesn't help:longest-pathhits the same error, andnetwork-simplexthrows a different one on the docs graph.The layout now runs in an effect instead of through
CytoscapeComponent'slayoutprop, so a failure can be caught. When dagre throws, the graph is laid out withfcose(force) and a short note says the chosen layout failed. Saved positions and the layout selector work as before.test_dvui008reproduces it with 8 callbacks reduced from the docs app. It fails on 4.5.1 and passes with this change. The othertest_devtools_ui.pytests still pass.