Repository navigation
test: don't override Fake::HTTP.new - #72
Merged
Merged
Conversation
GitHub: fix rubyGH-70 `Fake::HTTP.new` used `Class.method(:new).unbind.bind(self)` to bypass `Net::HTTP.new`. It fails with Ruby 4.1 because `Class.method(:new)` is a singleton method of `Class` now: ```text TypeError: singleton method called for a different object ``` We don't need to bypass `Net::HTTP.new`. We can use the default `Net::HTTP#initialize` and set responses by an attribute writer instead. Reported by Mamoru TASAKA. Thanks!!! Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This patch seems to work with both
|
Member
Author
|
Thanks. I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub: fix GH-70
Fake::HTTP.newusedClass.method(:new).unbind.bind(self)to bypassNet::HTTP.new. It fails with Ruby 4.1 becauseClass.method(:new)is a singleton method ofClassnow:We don't need to bypass
Net::HTTP.new. We can use the defaultNet::HTTP#initializeand set responses by an attribute writer instead.Reported by Mamoru TASAKA. Thanks!!!