Repository navigation
fix(endpoint): prevent KeyError in Job.stream() when stream key is missing or None - #745
Open
Mouhand-Kaddo wants to merge 1 commit into
Open
Mouhand-Kaddo wants to merge 1 commit into
Mouhand-Kaddo wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Job.stream()on a sync endpoint raisesKeyError: 'stream'(orTypeErrorwhen"stream": None) if/stream/{job_id}returns a terminal state (FAILED,TIMED_OUT, orCOMPLETED) without a"stream"key in the payload. The next line already used.get("stream", []), and the async runner only guarded missing keys, leaving"stream": Noneunhandled in both.Both sync and async
Job.stream()now normalizestream_partial.get("stream") or []before checking chunk length and yielding outputs, so terminal and in-progress responses with a missing orNone"stream"field exit or continue polling cleanly. Added unit tests coveringFAILED,TIMED_OUT, andCOMPLETEDresponses with missing andNone"stream"values alongside normal chunk streaming.Created with Gemini 4 Neon in T3 Code.