Repository navigation
fix(demo/argo-cd-git-ops): Point at the garage manifests - #495
Open
siegfriedweber wants to merge 1 commit into
Open
siegfriedweber wants to merge 1 commit into
siegfriedweber wants to merge 1 commit into
Conversation
7 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Point the Argo CD demo at the Garage manifests
The demo could not be installed. #486 renamed
projects/minio.yamlandapplications/minio.yamltogarage.yaml, but the two matchingplainYamlreferences indemos/demos-v2.yamlkept pointing at the old names, so the install failed to fetch them.The S3 endpoint snippet broke on dual-stack clusters. A dual-stack node reports more than one
InternalIPand kubectl joins jsonpath matches with a space, producing10.104.213.49 fd42:1961:e0c0:168a::1and a garbage URL. The snippet now takes the first address and brackets it when it is IPv6, since a bare IPv6 address in a URL is rejected outright. Fixed inpartials/inspect-s3.adoctoo, which seven other demo pages include.Verified against a dual-stack k3s cluster: both code blocks run verbatim out of the
.adocfiles, and the endpoint they derive answers a signedListObjectswith HTTP 200, returning the demo's Airflow task logs.Part of #489
Checklist
Author
Reviewer
Acceptance