Skip to content

fix(demo/argo-cd-git-ops): Point at the garage manifests - #495

Open
siegfriedweber wants to merge 1 commit into
mainfrom
fix/argo-cd-garage-manifest-refs
Open

siegfriedweber wants to merge 1 commit into
mainfrom
fix/argo-cd-garage-manifest-refs

Conversation

@siegfriedweber

Copy link
Copy Markdown
Member

Description

Point the Argo CD demo at the Garage manifests

The demo could not be installed. #486 renamed projects/minio.yaml and applications/minio.yaml to garage.yaml, but the two matching plainYaml references in demos/demos-v2.yaml kept pointing at the old names, so the install failed to fetch them.

The S3 endpoint snippet broke on dual-stack clusters. A dual-stack node reports more than one InternalIP and kubectl joins jsonpath matches with a space, producing 10.104.213.49 fd42:1961:e0c0:168a::1 and a garbage URL. The snippet now takes the first address and brackets it when it is IPv6, since a bare IPv6 address in a URL is rejected outright. Fixed in partials/inspect-s3.adoc too, which seven other demo pages include.

Verified against a dual-stack k3s cluster: both code blocks run verbatim out of the .adoc files, and the endpoint they derive answers a signed ListObjects with HTTP 200, returning the demo's Airflow task logs.

Part of #489

Checklist

Author

  • AI review done, findings addressed

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

@siegfriedweber
siegfriedweber requested a review from a team November 20, 2026 17:41
@siegfriedweber siegfriedweber self-assigned this Nov 20, 2026
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Nov 20, 2026

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants