Skip to content

ci: add timeouts and fail-fast guards to the workflows - #298

Open
metif12 wants to merge 1 commit into
vlang:masterfrom
metif12:ci/fail-fast-guards-timeouts
Open

metif12 wants to merge 1 commit into
vlang:masterfrom
metif12:ci/fail-fast-guards-timeouts

Conversation

@metif12

@metif12 metif12 commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

None of this repository's workflows stop early: a hung step burns GitHub's 6 hour default because no job sets \ imeout-minutes, and a failed step still runs every step after it.

  • Every job without one gets a \ imeout-minutes\ (60 minutes generally; higher where the workload justifies it, e.g. benchmark and OS-image jobs).
  • Steps after the first get an !cancelled()\ guard (GitHub's default \success()\ already skips the remaining steps after a hard failure), so a failure skips the rest of the job instead of spending the rest of the timeout. Steps that already carry their own condition keep it, and are never chained from a previous step's .outcome. This avoids skipping downstream steps when an earlier step is \continue-on-error\ (e.g. the non-blocking -autofree\ build in ci: stop gating PRs on V's own broken -autofree build #294).

This was applied mechanically and verified as a pure transformation: no step was added, removed, renamed or reordered, no
un:\ command was touched, and no runner image or toolchain changed.

@medvednikov medvednikov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness blocker when combined with #294: the -prod step (and subsequent CSS/tests) is gated on steps.compile_gitly_with_autofree.outcome == 'success'. #294 makes that -autofree step continue-on-error: true; on failure, GitHub records outcome: failure but conclusion: success. Your extra gate will then skip -prod and everything downstream while the job can appear green. Prefer removing the previous-step .outcome chains entirely—GitHub's default success() behavior already skips steps after hard failures—or gate on the effective .conclusion if needed. Separately, the PR description says test jobs receive VTEST_FAIL_FAST=1, but the actual diff contains no such setting; either add it or correct the description. The job timeouts themselves are a useful change.

@metif12

metif12 commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

Done - addressed in the latest push.

@medvednikov medvednikov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed head 2fa9b2a: the per-step .outcome chain that could skip downstream tests after continue-on-error is removed, leaving normal success() semantics; the description no longer claims an unimplemented VTEST_FAIL_FAST setting. Timeouts are present on all four jobs. Approved on workflow diff; CI statuses not considered.

Copy link
Copy Markdown
Member

Re-review update: approved at head 2fa9b2a, but GitHub rejected the requested squash merge with 405 Pull Request has merge conflicts after #293 was squash-merged.

The overlapping file is .github/workflows/ci.yml. On current master, the windows-gcc steps are now ordered Checkout V → Checkout gitly → Build V → Install SQLite → Compile gitly, and Install SQLite must keep run: .\gitly\.github\workflows\windows-install-sqlite.bat. This PR's workflow patch was authored against the old sequence/path.

Please rebase/update this branch onto current vlang/gitly/master, preserving #293's Windows step order/path, then apply this PR's job timeouts and id/if: ${{ success() && !cancelled() }} guards to the resulting steps. Keep the non-.outcome conditions and the current PR description (no unimplemented VTEST_FAIL_FAST claim). Once the conflict is resolved, this approved PR can be squash-merged. CI status was not considered in the source review.

Rebased onto upstream/master (a1c080f math), squashed feature commits
cde8c0f/ecdb779/2fa9b2a. Includes upstream windows/sqlite fixes.
Also includes green-CI fixes: makev.bat (V renamed make.bat),
markdown_test shadowing rename, search stars_count column.

Verified:
- v -d sqlite test highlight/markdown_test.v -> 1 passed
- v -cc gcc -d sqlite test search_test.v -> 1 passed
@metif12
metif12 force-pushed the ci/fail-fast-guards-timeouts branch from c921d3d to 6fb8c70 Compare November 13, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants