Repository navigation
Conversation
medvednikov
left a comment
There was a problem hiding this comment.
Correctness blocker when combined with #294: the -prod step (and subsequent CSS/tests) is gated on steps.compile_gitly_with_autofree.outcome == 'success'. #294 makes that -autofree step continue-on-error: true; on failure, GitHub records outcome: failure but conclusion: success. Your extra gate will then skip -prod and everything downstream while the job can appear green. Prefer removing the previous-step .outcome chains entirely—GitHub's default success() behavior already skips steps after hard failures—or gate on the effective .conclusion if needed. Separately, the PR description says test jobs receive VTEST_FAIL_FAST=1, but the actual diff contains no such setting; either add it or correct the description. The job timeouts themselves are a useful change.
|
Done - addressed in the latest push. |
medvednikov
left a comment
There was a problem hiding this comment.
Re-reviewed head 2fa9b2a: the per-step .outcome chain that could skip downstream tests after continue-on-error is removed, leaving normal success() semantics; the description no longer claims an unimplemented VTEST_FAIL_FAST setting. Timeouts are present on all four jobs. Approved on workflow diff; CI statuses not considered.
|
Re-review update: approved at head The overlapping file is Please rebase/update this branch onto current |
Rebased onto upstream/master (a1c080f math), squashed feature commits cde8c0f/ecdb779/2fa9b2a. Includes upstream windows/sqlite fixes. Also includes green-CI fixes: makev.bat (V renamed make.bat), markdown_test shadowing rename, search stars_count column. Verified: - v -d sqlite test highlight/markdown_test.v -> 1 passed - v -cc gcc -d sqlite test search_test.v -> 1 passed
c921d3d to
6fb8c70
Compare
None of this repository's workflows stop early: a hung step burns GitHub's 6 hour default because no job sets \ imeout-minutes, and a failed step still runs every step after it.
This was applied mechanically and verified as a pure transformation: no step was added, removed, renamed or reordered, no
un:\ command was touched, and no runner image or toolchain changed.