Repository navigation
feat(hub-ui): mark grouped docks shown outside their group - #498
Merged
Merged
Conversation
A recent or pinned group member on the dock bar now shows its group icon as a corner mark, and its tooltip shows the group title, so tools with similar icons from different groups stay apart.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
👁️🗨️ Review this pull request with grouped, summarized diffs at: raw result💭 analyzed by {
"headSha": "769693e64f8e2046841931812d02d18fb436e976",
"result": {
"overallSummary": "Small UI feature: docks shown on the bar outside their group (pinned or recently used) now get a small group-icon corner mark and a tooltip prefixed with the group title, so similar-looking icons from different groups can be told apart. Confined to three related files in `hub-ui`'s dock components and tooltip state.",
"groups": [
{
"key": "dock-group-mark",
"label": "Group mark on dock entries",
"summary": "Adds a corner mark and tooltip prefix showing which group a dock entry belongs to, when it is shown on the bar outside its group button (pinned or recent). `DockEntries` passes the dock's group to `DockEntry`, which renders the mark and forwards the group to `dockTooltipContent` for the tooltip prefix.",
"category": "ui",
"filePaths": [
"packages/hub-ui/src/client/components/dock/DockEntries.vue",
"packages/hub-ui/src/client/components/dock/DockEntry.vue",
"packages/hub-ui/src/client/state/floating-tooltip.ts"
],
"fileNotes": [
{
"path": "packages/hub-ui/src/client/components/dock/DockEntry.vue",
"text": "New optional `group` prop drives both the corner icon mark (bottom-right, to avoid clashing with the existing badge) and the tooltip prefix; docks without a group render unchanged."
},
{
"path": "packages/hub-ui/src/client/state/floating-tooltip.ts",
"text": "`dockTooltipContent` now accepts an optional `group` to prefix the tooltip title, e.g. `Nuxt › Pages`."
}
]
}
],
"schemaVersion": 1,
"source": "llm",
"generatedAt": "2026-11-19T01:18:34.209Z",
"model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
"locale": "en"
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dock bar raises recently opened tools (and pinned group members) into their own slots, outside their group button. Out there, two tools from different groups can have near-identical icons, and nothing shows which group each one comes from.
Now a dock shown on the bar outside its group gets:
Nuxt › Pages.Docks without a group, and group buttons themselves, look the same as before. The mark is drawn in
DockEntryfrom a new optionalgroupprop;DockEntries(used only for bar items) passes the dock's group via the existinggetEntryGroup.dockTooltipContenttakes an optional group to prefix the title.User prompts
Model: Claude Opus 5.5 in Claude Code (via Paseo).
Visual changes
Storybook
Dock Shell / Float Bar / With Pinned And Recent Members, dark, 640x200 @3x. The first item is a pinned group member, the last is a recent group member. Icons show as the warning-triangle fallback because the capture sandbox has no network access to Iconify; both sides render the same fallback.main)Verification
pnpm lint: pass.pnpm build, thenpnpm knip: pass.pnpm typecheck: pass.pnpm exec vitest run src/clientinpackages/hub-ui: 158 passed.pnpm test: 1872 passed, 5 failed, all outside hub-ui and not touched by this diff:tests/exports.test.ts(devframe ./internal,plugin-terminals ./node,plugin-code-server ./node): thenosticsdiagnosticstype output changed, which looks like it comes from the deps update in 13b26a3.packages/devframe/src/adapters/__tests__that need the IPv6 loopback ([::1]), not available in the local sandbox.This PR was written by an agent. The human gave the task and approved opening the PR; they have not reviewed the diff yet.