Skip to content

feat(hub-ui): mark grouped docks shown outside their group - #498

Merged
antfu merged 1 commit into
mainfrom
dock-tool-group-indicator
Nov 19, 2026
Merged

antfu merged 1 commit into
mainfrom
dock-tool-group-indicator

Conversation

@antfubot

Copy link
Copy Markdown
Collaborator

Summary

The dock bar raises recently opened tools (and pinned group members) into their own slots, outside their group button. Out there, two tools from different groups can have near-identical icons, and nothing shows which group each one comes from.

Now a dock shown on the bar outside its group gets:

  • a small corner mark with its group's icon (bottom-right, so it does not clash with the badge in the top-right), and
  • a tooltip that starts with the group title, for example Nuxt › Pages.

Docks without a group, and group buttons themselves, look the same as before. The mark is drawn in DockEntry from a new optional group prop; DockEntries (used only for bar items) passes the dock's group via the existing getEntryGroup. dockTooltipContent takes an optional group to prefix the title.

User prompts

Model: Claude Opus 5.5 in Claude Code (via Paseo).

  • Asked that recently used tools on the main dock show the group icon or another indicator, because their icons can look like other, separate tools.
  • Picked "run gates and open a PR" after reviewing the result.

Visual changes

Storybook Dock Shell / Float Bar / With Pinned And Recent Members, dark, 640x200 @3x. The first item is a pinned group member, the last is a recent group member. Icons show as the warning-triangle fallback because the capture sandbox has no network access to Iconify; both sides render the same fallback.

Before (main) After
Dock bar before Dock bar after
Recent tooltip before Recent tooltip after

Verification

  • pnpm lint: pass.
  • pnpm build, then pnpm knip: pass.
  • pnpm typecheck: pass.
  • pnpm exec vitest run src/client in packages/hub-ui: 158 passed.
  • pnpm test: 1872 passed, 5 failed, all outside hub-ui and not touched by this diff:
    • 3 dts snapshots in tests/exports.test.ts (devframe ./internal, plugin-terminals ./node, plugin-code-server ./node): the nostics diagnostics type output changed, which looks like it comes from the deps update in 13b26a3.
    • 2 network tests in packages/devframe/src/adapters/__tests__ that need the IPv6 loopback ([::1]), not available in the local sandbox.
  • Not verified: how real Iconify icons look at the 12px mark size, and the vertical (rotated) float bar.

This PR was written by an agent. The human gave the task and approved opening the PR; they have not reviewed the diff yet.

A recent or pinned group member on the dock bar now shows its group icon as a corner mark, and its tooltip shows the group title, so tools with similar icons from different groups stay apart.
@vercel

vercel Bot commented Nov 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
devframe Ignored Ignored Nov 19, 2026 1:18am UTC

@github-actions

Copy link
Copy Markdown

👁️‍🗨️ Review this pull request with grouped, summarized diffs at:
👉 https://pulls.review/gh/devframes/devframe/498?from=github-actions[bot]

raw result

💭 analyzed by vercel-ai-gateway/anthropic/claude-sonnet-5
🕰️ 2026-11-19 01:18 UTC
🔗 head 769693e
🤖 automated by pulls.review

{
  "headSha": "769693e64f8e2046841931812d02d18fb436e976",
  "result": {
    "overallSummary": "Small UI feature: docks shown on the bar outside their group (pinned or recently used) now get a small group-icon corner mark and a tooltip prefixed with the group title, so similar-looking icons from different groups can be told apart. Confined to three related files in `hub-ui`'s dock components and tooltip state.",
    "groups": [
      {
        "key": "dock-group-mark",
        "label": "Group mark on dock entries",
        "summary": "Adds a corner mark and tooltip prefix showing which group a dock entry belongs to, when it is shown on the bar outside its group button (pinned or recent). `DockEntries` passes the dock's group to `DockEntry`, which renders the mark and forwards the group to `dockTooltipContent` for the tooltip prefix.",
        "category": "ui",
        "filePaths": [
          "packages/hub-ui/src/client/components/dock/DockEntries.vue",
          "packages/hub-ui/src/client/components/dock/DockEntry.vue",
          "packages/hub-ui/src/client/state/floating-tooltip.ts"
        ],
        "fileNotes": [
          {
            "path": "packages/hub-ui/src/client/components/dock/DockEntry.vue",
            "text": "New optional `group` prop drives both the corner icon mark (bottom-right, to avoid clashing with the existing badge) and the tooltip prefix; docks without a group render unchanged."
          },
          {
            "path": "packages/hub-ui/src/client/state/floating-tooltip.ts",
            "text": "`dockTooltipContent` now accepts an optional `group` to prefix the tooltip title, e.g. `Nuxt › Pages`."
          }
        ]
      }
    ],
    "schemaVersion": 1,
    "source": "llm",
    "generatedAt": "2026-11-19T01:18:34.209Z",
    "model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
    "locale": "en"
  }
}

@antfu
antfu merged commit 26e0d45 into main Nov 19, 2026
8 of 16 checks passed
@antfu
antfu deleted the dock-tool-group-indicator branch November 19, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants